automatic reputation for search engines

text.go

@@ -4,32 +4,19 @@ import (
 	"fmt"
 	"html/template"
 	"log"
-	"math/rand"
 	"net/http"
-	"sync"
 	"time"
 )
 
-var (
-	searchEngines    []searchEngine
-	searchEngineLock sync.Mutex
-)
-
-type searchEngine struct {
-	Name   string
-	Func   func(string, string, string, int) ([]TextSearchResult, error)
-	Weight int
-}
+var textSearchEngines []SearchEngine
 
 func init() {
-	searchEngines = []searchEngine{
-		{Name: "Google", Func: PerformGoogleTextSearch, Weight: 1},
-		{Name: "LibreX", Func: PerformLibreXTextSearch, Weight: 2},
-		// {Name: "DuckDuckGo", Func: PerformDuckDuckGoTextSearch, Weight: 3}, // DuckDuckGo timeouts too fast and search results are trash
-		// {Name: "SearXNG", Func: PerformSearXNGTextSearch, Weight: 2}, // Uncomment when implemented
+	textSearchEngines = []SearchEngine{
+		{Name: "Google", Func: wrapTextSearchFunc(PerformGoogleTextSearch), Weight: 1},
+		{Name: "LibreX", Func: wrapTextSearchFunc(PerformLibreXTextSearch), Weight: 2},
+		{Name: "DuckDuckGo", Func: wrapTextSearchFunc(PerformDuckDuckGoTextSearch), Weight: 3}, // DuckDuckGo timeouts too fast and search results are trash
+		// {Name: "SearXNG", Func: wrapTextSearchFunc(PerformSearXNGTextSearch), Weight: 2}, // Uncomment when implemented
 	}
-
-	rand.Seed(time.Now().UnixNano())
 }
 
 func HandleTextSearch(w http.ResponseWriter, query, safe, lang string, page int) {
@@ -103,17 +90,24 @@ func prefetchPage(query, safe, lang string, page int) {
 func fetchTextResults(query, safe, lang string, page int) []TextSearchResult {
 	var results []TextSearchResult
 	var err error
+	var duration time.Duration
 
-	for attempts := 0; attempts < len(searchEngines); attempts++ {
-		engine := selectSearchEngine()
+	for attempts := 0; attempts < len(textSearchEngines); attempts++ {
+		engine := selectSearchEngine(textSearchEngines)
 		log.Printf("Using search engine: %s", engine.Name)
 
-		results, err = engine.Func(query, safe, lang, page)
+		var searchResults []SearchResult
+		searchResults, duration, err = engine.Func(query, safe, lang, page)
+		updateEngineMetrics(&engine, duration, err == nil)
 		if err != nil {
 			log.Printf("Error performing search with %s: %v", engine.Name, err)
 			continue
 		}
 
+		for _, result := range searchResults {
+			results = append(results, result.(TextSearchResult))
+		}
+
 		if len(results) > 0 {
 			break
 		}
@@ -122,32 +116,18 @@ func fetchTextResults(query, safe, lang string, page int) []TextSearchResult {
 	return results
 }
 
-func selectSearchEngine() searchEngine {
-	searchEngineLock.Lock()
-	defer searchEngineLock.Unlock()
-
-	totalWeight := 0
-	for _, engine := range searchEngines {
-		totalWeight += engine.Weight
-	}
-
-	randValue := rand.Intn(totalWeight)
-	for _, engine := range searchEngines {
-		if randValue < engine.Weight {
-			// Adjust weights for load balancing
-			for i := range searchEngines {
-				if searchEngines[i].Name == engine.Name {
-					searchEngines[i].Weight = max(1, searchEngines[i].Weight-1)
-				} else {
-					searchEngines[i].Weight++
-				}
-			}
-			return engine
+func wrapTextSearchFunc(f func(string, string, string, int) ([]TextSearchResult, time.Duration, error)) func(string, string, string, int) ([]SearchResult, time.Duration, error) {
+	return func(query, safe, lang string, page int) ([]SearchResult, time.Duration, error) {
+		textResults, duration, err := f(query, safe, lang, page)
+		if err != nil {
+			return nil, duration, err
 		}
-		randValue -= engine.Weight
+		searchResults := make([]SearchResult, len(textResults))
+		for i, result := range textResults {
+			searchResults[i] = result
+		}
+		return searchResults, duration, nil
 	}
-
-	return searchEngines[0] // fallback to the first engine
 }
 
 func displayResults(w http.ResponseWriter, results []TextSearchResult, query, lang string, elapsed float64, page int, hasPrevPage, hasNextPage bool) {